Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datasource): Add datasource for buildpack registry #32721

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

c0d1ngm0nk3y
Copy link

@c0d1ngm0nk3y c0d1ngm0nk3y commented Nov 25, 2024

Changes

This introduces a datasource to handle buildpack registry entries for Cloud Native Buildpacks.

Context

In addition to the existing handling of the project.toml, the newly added datasource handles entries that are not referring to docker images, but that are https://buildpacks.io/docs/for-app-developers/how-to/build-inputs/specify-buildpacks/ .

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: Michael Kriese <[email protected]>
Co-authored-by: Pavel Busko <[email protected]>
Co-authored-by: Johannes Dillmann <[email protected]>
Co-authored-by: Nicolas Bender <[email protected]>
@viceice viceice changed the title Add datasource for buildpack registry feat(datasource): Add datasource for buildpack registry Nov 26, 2024
@CLAassistant
Copy link

CLAassistant commented Nov 26, 2024

CLA assistant check
All committers have signed the CLA.

@c0d1ngm0nk3y c0d1ngm0nk3y requested a review from viceice November 28, 2024 09:55
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs lint fixes

lib/modules/datasource/buildpacks-registry/index.spec.ts Outdated Show resolved Hide resolved
lib/modules/datasource/buildpacks-registry/index.spec.ts Outdated Show resolved Hide resolved
lib/modules/datasource/buildpacks-registry/index.ts Outdated Show resolved Hide resolved
lib/modules/manager/buildpacks/extract.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/buildpacks/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/buildpacks/extract.ts Show resolved Hide resolved
lib/modules/manager/buildpacks/schema.ts Outdated Show resolved Hide resolved
lib/modules/manager/buildpacks/schema.ts Outdated Show resolved Hide resolved
@c0d1ngm0nk3y c0d1ngm0nk3y requested a review from viceice November 29, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants